[History server] Skip directory markers when listing storage - #5236
Open
win5923 wants to merge 1 commit into
Open
[History server] Skip directory markers when listing storage#5236win5923 wants to merge 1 commit into
win5923 wants to merge 1 commit into
Conversation
Signed-off-by: win5923 <ken89@kimo.com>
Member
Author
|
Should we stop calling This would also avoid creating directory marker objects in the first place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When the History Server reads cluster metadata from object storage, directory marker objects created by
StorageWriter.CreateDirectoryare returned alongside the actual session markers.The directory marker is a 0-byte object, not a metadata file, but
List()passes it toDecodePath(), causing a misleading error:List(): a placeholder has one path segment too few for DecodePath, so every /clusters and /enter_cluster request logged one parse error per cluster in the bucket.kuberay/historyserver/pkg/storage/clustermetadata/clustermetadata.go
Lines 40 to 54 in 215b98f
_listFiles(): a placeholder surfaced as an entry named after its own directory, leaking into /api/v0/logs?glob=** as "events/events".Changes:
utils.IsDirectoryMarker.s3,aliyunoss, in bothList()and_listFiles().List()already filters them via MatchGlob, and _listFiles() via HasSuffix.CreateDirectoryis a no-op, so it does not create directory marker objects.Related issue number
Labels
doc-updates-requiredlabel.breaking-changelabel.Checks
Manual test instructions