[History Server] Add unit tests for timeline pure functions - #5231
Open
AlterHoodie wants to merge 1 commit into
Open
[History Server] Add unit tests for timeline pure functions#5231AlterHoodie wants to merge 1 commit into
AlterHoodie wants to merge 1 commit into
Conversation
Contributor
Author
|
@win5923 On a side note, Should be fine as long as Ray profiling data does not produce this in practice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Adds unit tests for the History Server timeline pure functions. getTasksTimeline reaches 97.4% coverage. The remaining lines are defensive guards for PID/TID lookup failures that cannot be hit with the current two pass design, since both passes use the same filteredTasks data.
Closes Sub-Issue 3 in #5222
Checks