K8s 1.37 client go / envtest updates - #5226
Conversation
f4aec5a to
eb84247
Compare
eb84247 to
d07bf5a
Compare
| 1.37 client libraries. | ||
|
|
||
| This directory contains a frozen copy of the following files from | ||
| `k8s.io/api/scheduling/v1alpha2` at `v0.36.0`: |
There was a problem hiding this comment.
Actually, I think we can move to scheduling.k8s.io/v1alpha3 directly. We can ask users to keep using the old kuberay if they require k8s.io/api/scheduling/v1alpha2.
There was a problem hiding this comment.
Agree, we do not need to copy the whole type here
There was a problem hiding this comment.
I would need to update things like the kindconfig used in CI for the v1alpha2 e2e test job and things if we want to switch the current WAS plugin too (and maybe a few other things)
I think it might be cleaner to just keep the v1alpha2 files around for now.
If you all are really against this I can do testing for the v1alpha3 support and include that here.
Let me know!
There was a problem hiding this comment.
+1 move to scheduling.k8s.io/v1alpha3
There was a problem hiding this comment.
Yes I think we can move to v1alpha3 in this PR, as v1alpha2 files will eventually be removed (either this or follow-up PR), we can just do that here
There was a problem hiding this comment.
ok! let me work on that and i'll update this PR
There was a problem hiding this comment.
I updated all the existing v1alpha2 references to v1alpha3 but DID NOT change any behaviors.
I have work done in another branch to implement support for new behaviors (specifically support mutable PodGroup minCount / enable WAS for autoscaling clusters and support for PodGroupPremptionPolicy)).
After this merges I'll rebase those changes on here and open up a new PR.
Signed-off-by: Mark Rossetti <marosset@microsoft.com>
Signed-off-by: Mark Rossetti <marosset@microsoft.com>
Signed-off-by: Mark Rossetti <marosset@microsoft.com>
Signed-off-by: Mark Rossetti <marosset@microsoft.com>
Signed-off-by: Mark Rossetti <marosset@microsoft.com>
d07bf5a to
ebaecc0
Compare
Why are these changes needed?
K8s v1.37 is out and this is also a prereq for continues the WAS work to support K8s v1.37 scheduling APIS
This PR updates client-go and envtest targets to K8s v1.37 in all packages in the repo (including podpool and historyserver)
A few notes:
historyservermakefile which was causing which was causing files to not get formatted so that changes are also included.Related issue number
Labels
doc-updates-requiredlabel.breaking-changelabel.Checks
Manual test instructions