Make generators methods public static; document the convention#11
Merged
Conversation
Generators/examples methods are invoked via reflection only, so Rector's RemoveUnusedPrivateMethodRector (deadCode set) deletes private ones. Public static is safe: no dead-code rule touches public methods and Testo never treats a non-void-returning method as a test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generators/examples methods are invoked via property-testing's reflection only — they have no static call sites. Rector's
RemoveUnusedPrivateMethodRector(deadCode set) therefore deletes private ones, silently killing property tests onrector:fix(recent rector releases tightened the rule; every consumer with private generators is latently red on a fresh install).The convention fix that needs no rector configuration anywhere: declare them
public static(publicif the body needs$this). No dead-code rule touches public methods, and Testo never treats a non-void-returning method as a test.GenPropertyTest) and examples (property_test.php,state_machine.php) — stubs already werepublic static.No code changes: the resolver accepts any visibility. Docs+tests only — no release needed.