fixed symbol used and mixed up ports - #6
Open
moeskerv wants to merge 2 commits into
Open
Conversation
TCCR0A uses CS0x bits while CS1x bits belong to TCCR1B according to spec this change is just for better readability, value of CS12 == CS02 Signed-off-by: Volker Moesker <moeskerv@gmail.com>
usage of PORTC/PORTB and LED_OE_N/FRAME_INT was mixed up FRAME_INT is connected to PORTB LED_OE_N is connected to PORTC Signed-off-by: Volker Moesker <moeskerv@gmail.com>
Contributor
|
Thanks, will take a look when when I get a chance to work on sense hat stuff again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While studying the code I observed some small issues in the code - none of them had functional impact but for clean-up and better readability it could make sense to check my changes.
Thanks a lot for this great stuff!
BR,
Volker