Include playground_auto_set_url - #47
Open
jcarranz97 wants to merge 5 commits into
Open
Conversation
lurch
reviewed
Dec 4, 2023
lurch
reviewed
Dec 4, 2023
Contributor
Author
|
Thanks for the advice. I have made the change and I have also include PICO_PLAYGROUND_PATH in the CMakeLists.txt |
lurch
removed their request for review
December 7, 2023 09:47
Contributor
Author
|
Hi! Just following up on this PR — it's been open for quite some time and I wanted to check in. Is there any chance this could be merged at some point, or would it be better to close it? I'm doing a bit of cleanup on my open PRs and just trying to keep things tidy. No rush at all — thanks! |
Contributor
|
See my comment on your other PR... 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46
Include modified version of
example_auto_set_url.cmaketo be able to useexample_auto_set_url