Build in devcontainers in CI - #371
Open
bdice wants to merge 2 commits into
Open
Conversation
mattgara
reviewed
Jul 22, 2026
mattgara
left a comment
mattgara
left a comment
Contributor
There was a problem hiding this comment.
One issue related to credentials exposure, but otherwise LGTM.
| imageTag: cuda${{ matrix.cuda }}-${{ matrix.arch }} | ||
| cacheFrom: ghcr.io/rapidsai/velox-testing/devcontainer:latest-cuda${{ matrix.cuda }} | ||
| env: | | ||
| AWS_ACCESS_KEY_ID=${{ env.AWS_ACCESS_KEY_ID }} |
Contributor
There was a problem hiding this comment.
This looks to pass a 12-hour AWS session plus an sccache auth token into code from the PR checkout. I'm not sure in what context the dev containers are supposed to be used, but could we consider moving this credentialed build behind a manually dispatched workflow on main and a protected trusted-pr-build environment, with a manually maintained trusted team as required reviewers? This is mostly to prevent someone accessing said credentials in their PR's container unbeknownst to us.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables devcontainer builds in CI for verification of builds.