Skip to content

Fix TPC-H decimal fixtures and log schemas - #367

Open
bdice wants to merge 1 commit into
rapidsai:mainfrom
bdice:fix/tpch-decimal-fixtures-schema-logging
Open

Fix TPC-H decimal fixtures and log schemas#367
bdice wants to merge 1 commit into
rapidsai:mainfrom
bdice:fix/tpch-decimal-fixtures-schema-logging

Conversation

@bdice

@bdice bdice commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • regenerate the tracked SF0.01 TPC-H fixtures with physical INT64 values annotated as DECIMAL(15,2)
  • add regression coverage tying the committed Parquet decimals to the static Presto schemas
  • log Parquet physical/logical schemas and registered Presto SHOW CREATE TABLE output in CI
  • run the fixture regression when benchmark tools, TPC-H fixtures, or TPC-H schemas change

Root cause

The static Presto TPC-H schemas changed to DECIMAL, but the tracked SF0.01 fixtures still contained DuckDB-generated DOUBLE columns. Clean local runs therefore failed even though CI passed with freshly generated decimal data.

Validation

  • benchmark_data_tools/.venv/bin/pytest -q benchmark_data_tools/tests: 12 passed
  • repository pre-commit hooks: passed
  • local GPU run with the exact CI coordinator and worker images: 21/21 TPC-H queries passed in 16.94s
  • schema logs confirmed all nine monetary fields are physical INT64 with logical Decimal(precision=15, scale=2), matching registered Presto decimal(15,2) columns

@copy-pr-bot

copy-pr-bot Bot commented Jul 2, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@bdice
bdice marked this pull request as ready for review July 2, 2026 21:34
@bdice
bdice requested a review from a team as a code owner July 2, 2026 21:34
@bdice
bdice requested a review from mattgara July 2, 2026 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant