Regenerate tiny TPC-H data with decimals - #366
Draft
bdice wants to merge 1 commit into
Draft
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The committed tiny TPC-H files still stored monetary and quantity columns as
DOUBLE, while the table schemas declared those columns asDECIMAL(15,2). Registering the decimal schemas over the float fixture caused GPU integration failures from physical/logical type mismatches.Impact
Local and lightweight integration runs now exercise the same decimal TPC-H types as CI instead of silently using the older float fixture.
Validation
decimal128(15,2)and no fixture columns are floating-pointpython -m pytest -q benchmark_data_tools/tests/decimal_conversion_test.py