Skip to content

Add Presto image pull helper - #362

Open
misiugodfrey wants to merge 1 commit into
mainfrom
misiug/IBMPrestoImages
Open

Add Presto image pull helper#362
misiugodfrey wants to merge 1 commit into
mainfrom
misiug/IBMPrestoImages

Conversation

@misiugodfrey

@misiugodfrey misiugodfrey commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add presto/scripts/pull_presto_images.sh to pull prebuilt Presto coordinator/native GPU worker images and retag them for the existing start scripts.
  • Keep the user-facing image pull surface small: default PrestoDB images, --source ci, --tag, --local-tag, --cuda-version, --no-coordinator, and --dry-run.
  • Support custom PrestoDB tags such as latest, plus suffixed RAPIDS CI tag bodies such as c0de72d-velox-f374779-20260616-manual-27588892754.
  • Launch upstream PrestoDB GPU worker images through the velox-testing profiling/config wrapper and tolerate images that do not include numactl.
  • Document the simplified PrestoDB and RAPIDS CI image workflows in presto/README.md.

Test plan

  • bash -n presto/scripts/pull_presto_images.sh
  • ./presto/scripts/pull_presto_images.sh --help
  • Dry-run default PrestoDB image resolution.
  • Dry-run custom PrestoDB tag resolution with --tag latest.
  • Dry-run default RAPIDS CI image resolution with --source ci.
  • Dry-run custom RAPIDS CI tag resolution with --source ci --tag c0de72d-velox-f374779-20260616-manual-27588892754.
  • Dry-run retained options: --source ci --cuda-version 12.8, --no-coordinator, and --source ci --no-coordinator.
  • Verify expected failures for invalid source, invalid custom CI tag, and --cuda-version without --source ci.
  • git diff --check
  • Pull default PrestoDB images, start native GPU Presto, and run TPC-H Q1: passed, 469 ms.
  • Pull default RAPIDS CI images, start native GPU Presto, and run TPC-H Q1: passed, 519 ms.
  • Pull custom PrestoDB images with --tag latest, start native GPU Presto, and run TPC-H Q1: passed, 533 ms.
  • Pull custom RAPIDS CI images with --source ci --tag c0de72d-velox-f374779-20260616-manual-27588892754, start native GPU Presto, and run TPC-H Q1: passed, 539 ms.

@misiugodfrey
misiugodfrey requested a review from a team as a code owner June 16, 2026 18:45
@misiugodfrey
misiugodfrey requested a review from shrshi June 16, 2026 18:45
@copy-pr-bot

copy-pr-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@misiugodfrey
misiugodfrey force-pushed the misiug/IBMPrestoImages branch 2 times, most recently from 534b930 to ecd30ec Compare June 16, 2026 20:52
@misiugodfrey
misiugodfrey force-pushed the misiug/IBMPrestoImages branch from ecd30ec to aa72fb6 Compare June 16, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant