Forward TPC-H scale factor to benchmark pytest runner - #361
Open
pentschev wants to merge 1 commit into
Open
Conversation
This fixes NVL72 Presto benchmark runs where `launch-run.sh -s <SF>` correctly sets the schema/launcher scale factor, but `run_benchmark.sh` does not forward that value to pytest. Without this, the TPC-H query fixture falls back to reading `metadata.json` next to the mounted dataset and can fail with `KeyError: 'scale_factor'` before any query runs. Changes: - Add `--scale-factor` support to `presto/scripts/run_benchmark.sh`. - Pass the SLURM launcher scale factor through `presto/slurm/presto-nvl72/functions.sh`. - Make `get_scale_factor_from_file()` accept both top-level `scale_factor` and nested `options.scale_factor`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes NVL72 Presto benchmark runs where
launch-run.sh -s <SF>correctly sets the schema/launcher scale factor, butrun_benchmark.shdoes not forward that value to pytest.Without this, the TPC-H query fixture falls back to reading
metadata.jsonnext to the mounted dataset and can fail withKeyError: 'scale_factor'before any query runs.Changes:
--scale-factorsupport topresto/scripts/run_benchmark.sh.presto/slurm/presto-nvl72/functions.sh.get_scale_factor_from_file()accept both top-levelscale_factorand nestedoptions.scale_factor.