Retry presto-deps dependency downloads on transient network failures - #359
Open
Avinash-Raj wants to merge 1 commit into
Open
Retry presto-deps dependency downloads on transient network failures#359Avinash-Raj wants to merge 1 commit into
Avinash-Raj wants to merge 1 commit into
Conversation
Avinash-Raj
commented
Jun 9, 2026
| # - /etc/wgetrc covers the remaining direct `wget` downloads (e.g. minio) | ||
| dockerfile=presto-deps-context/scripts/dockerfiles/centos-dependency.dockerfile | ||
| sed -i \ | ||
| -e '/^ENV UCX_VERSION/a ENV CURL_OPTIONS="--retry 5 --retry-delay 5 --retry-all-errors --retry-connrefused --connect-timeout 30"' \ |
Contributor
Author
There was a problem hiding this comment.
Since this append happens after ENV UCX_VERSION line and we believe that the line should always be exists on the presto's centos deps dockerfile.
Avinash-Raj
commented
Jun 9, 2026
| -e '/^ENV UCX_VERSION/a ENV CURL_OPTIONS="--retry 5 --retry-delay 5 --retry-all-errors --retry-connrefused --connect-timeout 30"' \ | ||
| -e '/^ENV UCX_VERSION/a RUN { echo retries=10; echo timeout=60; echo minrate=500; } >> /etc/dnf/dnf.conf && { echo tries=5; echo timeout=30; echo waitretry=5; echo retry_connrefused=on; echo read_timeout=300; } >> /etc/wgetrc' \ | ||
| "$dockerfile" | ||
| grep -q '^ENV CURL_OPTIONS=' "$dockerfile" || { echo "::error::failed to inject network-retry config (anchor 'ENV UCX_VERSION' not found in upstream dockerfile)"; exit 1; } |
Contributor
Author
There was a problem hiding this comment.
Else it won't build the deps image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
presto-depsimage build runs many unguardedcurl/wget/dnfdownloads from upstreamPresto/Veloxsetup scripts, which intermittently fail on transient network blips. Inject retry/timeout config into the staged dependency Dockerfile so those downloads become resilient without forking the upstream scripts:CURL_OPTIONS(honoured by velox'swget_and_untar) for curl tarball fetchesdnf.confretries/timeout/minrate for dnf installs (incl. the CUDA repo)/etc/wgetrctries/wait,retry for direct wget downloadsA grep guard fails the step loudly if the upstream Dockerfile anchor changes.
This failure should be addressed by this PR, which allows the curl command to retry on network failures.