fix(math): geomLineIntersection returns null when segments share a start point#309
Merged
Merged
Conversation
…art point When a0 === b0, qpx and qpy are both 0, making uNumerator = 0. The condition `if (uNumerator && denominator)` treated a falsy uNumerator as a reason to skip the intersection check entirely — but u = 0 is a valid intersection at t = 0, u = 0 (the shared start point). Fix: only gate on `denominator` (parallel segments). A zero uNumerator just means u = 0, which is within the valid [0, 1] range. Adds a regression test with real-world geographic coordinates where a0 and b0 are coincident.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
geomLineIntersectionreturnednullwhena0andb0are the same point, even though the intersection is well-defined (it's that shared point).Root cause: when
a0 === b0, bothqpxandqpyare0, souNumerator = 0. The condition:treated a falsy
uNumeratoras a reason to skip the check entirely — butu = 0is a perfectly valid intersection parameter (the intersection is att = 0, u = 0, i.e. the shared start point).Fix
Only gate on
denominator(which being zero means the segments are parallel). A zerouNumeratorsimply meansu = 0, which is within the valid[0, 1]range.Test
Added a regression test using real-world geographic coordinates where
a0andb0are coincident.