Fix msftidy lint failures introduced after revert - #21735
Conversation
|
Hey @bwatters-r7, just a quick ping on this! I moved the lint fixes we reverted in #21715 over here. Take a look whenever you get a chance. |
|
|
||
| # Saves a new page to the vBulletin install | ||
| def save_page(nodeid, userid, pt_id, payload_url, wi_id, session_info) | ||
| def save_vbulletin_page(nodeid, userid, pt_id, payload_url, wi_id, session_info) |
There was a problem hiding this comment.
I don't see where this is defined
There was a problem hiding this comment.
Yeah you're right, there was actually no lint issue here. I got confused with the prtg module failing CI and incorrectly assumed this needed a rename. Just force-pushed to revert this.
There was a problem hiding this comment.
Pull request overview
This PR addresses msftidy/rubocop lint failures in two Metasploit exploit modules by (1) renaming a vBulletin helper method that collided with a debugger-related lint rule, and (2) removing redundant top-level module metadata now derived from target definitions.
Changes:
- Renamed
save_pagetosave_vbulletin_pagein the vBulletin module and updated its call site to avoid aLint/Debuggerfalse-positive name collision. - Removed redundant top-level
'Platform' => 'win'from the PRTG module since platform is already defined at the target level (and merged automatically).
Impact Analysis: isolated change; no meaningful downstream impact identified from diff.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| modules/exploits/multi/http/vbulletin_getindexablecontent.rb | Renames an internal helper method and updates its usage to avoid a lint false-positive. |
| modules/exploits/windows/http/prtg_authenticated_rce_cve_2023_32781.rb | Removes redundant module-level platform metadata already present in targets. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
cb00e2c to
ef134c9
Compare
This PR resolves two
msftidy/rubocoplint errors that surfaced after reverting unrelated Rubocop fixes in my recent PR:#21715
Changes:
modules/exploits/multi/http/vbulletin_getindexablecontent.rb:Renamed
save_pagetosave_vbulletin_page. The original method name triggered a false-positiveLint/Debuggerwarning due to a name collision with Capybara's debug helper. It is a legitimate exploit method that sends a POST request to/admin/savepage, not a leftover development debug call.modules/exploits/windows/http/prtg_authenticated_rce_cve_2023_32781.rb:Removed the redundant top-level
Platformdefinition. Since Merge target info into the module info #20786, the framework automatically merges target-level Platform/Arch entries into the module's top-level metadata, so this explicit definition is no longer needed and was correctly flagged byLint/ModuleRedundantArchPlatform.(Note: I previously attempted to include this cleanup in PR Fix 'successfully' typos in module console outputs #21715, but reverted it there since it was out of scope. Submitting it properly here.)
Both changes are lint/style fixes only — no functional or exploit logic was modified.