Remove rspec test focus, and ensure all tests run - #13820
Merged
jmartin-tech merged 1 commit intoJul 7, 2020
Merged
Conversation
adfoster-r7
force-pushed
the
remove-focused-test-and-ensure-all-tests-run
branch
from
July 7, 2020 16:10
418d9f1 to
6b93972
Compare
adfoster-r7
force-pushed
the
remove-focused-test-and-ensure-all-tests-run
branch
from
July 7, 2020 16:29
6b93972 to
2509bbf
Compare
adfoster-r7
commented
Jul 7, 2020
adfoster-r7
commented
Jul 7, 2020
adfoster-r7
commented
Jul 7, 2020
|
|
||
| # if the module eval error includes the module_path then the module_path was passed along correctly | ||
| expect(subject).to receive(:elog).with(/#{Regexp.escape(module_path)}/) | ||
| expect(subject).to receive(:elog).with(/#{Regexp.escape(module_path)}/, error: an_instance_of(NoMethodError)) |
Contributor
Author
There was a problem hiding this comment.
The error is from the malformed module content intentionally having a mistake:
# purposeful typo to check that module path is used in backtrace
inclde Exploit::Remote::Tcp
Which results in a NoMethodError being raised
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only one test is currently being run within the test suite due to an unintentional commit of
focus: trueon the rspec test suite.There will be a separate pull request created to ensure that this mistake can't happen in the futureAdding the fail safe to this pull request