Add consistent error logging for module loading and handle nil backtraces - #13757
Merged
adfoster-r7 merged 1 commit intoJun 23, 2020
Conversation
agalway-r7
reviewed
Jun 23, 2020
| if error.backtrace | ||
| error_details << "\nCall stack:\n#{error.backtrace.join("\n")}" | ||
| else | ||
| error_details << "\nCall stack:\nnone" |
Contributor
There was a problem hiding this comment.
Suggested change
| error_details << "\nCall stack:\nnone" | |
| error_details << "\nCall stack:\nNone" |
agalway-r7
approved these changes
Jun 23, 2020
agalway-r7
left a comment
agalway-r7
left a comment
Contributor
There was a problem hiding this comment.
LGTM, tested locally so I'm happy to merge once my pedantic capitalization suggestion is resolved
adfoster-r7
force-pushed
the
add-consistent-error-logging-for-module-loading
branch
from
June 23, 2020 10:15
ddbfc07 to
2439342
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependent on #13430
Updating the new error logging API to correctly handle the backtrace array being
nil, which occurs when custom exception objects are created and passed toelog:metasploit-framework/lib/msf/core/modules/loader/executable.rb
Line 84 in 6d6f539
Example:
Verification
List the steps needed to make sure this thing works
exploit/windows/smb/ms08_067_netapimsfconsoleuse exploit/windows/smb/ms08_067_netapiset LogLevel 3use exploit/windows/smb/ms08_067_netapi