feat: implement the public metadata issuance protocol#56
Open
karx1 wants to merge 13 commits into
Open
Conversation
thibmeu
reviewed
Jun 17, 2026
thibmeu
left a comment
There was a problem hiding this comment.
two main comments:
- there should be cross implementation test, with typescript/go. Typescript provides a JSON that has been generated by the go implementation, might be the simplest to consume
- I'm not sure the interface is the right one. I feel that there are way to extend method solely based on the type without introducing
TokenProtocolstructure
Author
|
I've addressed most of the review comments, and now I'm looking to see how to best address the compatibility requirements between the older and newer versions of |
thibmeu
reviewed
Jun 22, 2026
thibmeu
reviewed
Jun 23, 2026
thibmeu
reviewed
Jun 23, 2026
Author
|
I've decided to drop the backwards compatibility handling and conform strictly to |
Author
|
Also, RFC 9577 §2.2.2 says the token field might be a quoted-string, so I'm implementing changes accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the issuance protocol for Publicly Verifiable tokens with Public Metadata (token type
0xDA7A).This is a revival of #25, rebased onto the current
mainbranch and updated to support draft-ietf-privacypass-public-metadata-issuance-03. This PR also addresses the feedback from that PR.This PR also pins
voprfto version0.6.0-pre.0, as cargo automatically updating to0.6.0-pre.1was causing compilation errors on a clean build with noCargo.lock.Finally, the functions
verify_tokenandparse_authorization_str/parse_authorization_str_extare some QoL additions that helped during development, but I'm happy to remove those if needed.