Skip to content

Update patch file to use new default in config.pl - #2

Open
D-sha wants to merge 1 commit into
raoulbhatia:DEBIANfrom
D-sha:DEBIAN-4.2.1
Open

Update patch file to use new default in config.pl#2
D-sha wants to merge 1 commit into
raoulbhatia:DEBIANfrom
D-sha:DEBIAN-4.2.1

Conversation

@D-sha

@D-sha D-sha commented May 15, 2018

Copy link
Copy Markdown

Hi,
It seems the par default value in config.pl has changed and i was unable to build the package untill i changed this value in the patch file.
Hope this helps,
Cheers

@raoulbhatia

Copy link
Copy Markdown
Owner

Thanks @D-sha

However, I am not able to see this change in the source tree, see
https://github.com/raoulbhatia/backuppc/blob/master/conf/config.pl#L278 and upstream https://github.com/backuppc/backuppc/blob/master/conf/config.pl#L278

Can you please verify when building from a clean checkout and share the output showing the error?

Thanks,
Raoul

@raoulbhatia raoulbhatia self-assigned this May 16, 2018
@raoulbhatia
raoulbhatia self-requested a review May 16, 2018 06:31
@D-sha

D-sha commented May 24, 2018

Copy link
Copy Markdown
Author

I was confused to as to where this came from too. I believe it might be here:
debian/rules#L84

Removing this line might be a better solution?
Or just remove the hunk from the diff file?

Cheers,
Dean

@raoulbhatia

Copy link
Copy Markdown
Owner

Ah - good catch!

Unfortunately, I don't have time right now to work on this. I've created #4 as prep work and #6 that is aligned with some thing you're trying to achieve.

Would you be able to try if you can move the debian.config.diff to debian/patches/ and make that work with an updated config that includes potential changes from 94a7b92 ?

@raoulbhatia
raoulbhatia changed the base branch from DEBIAN-4.2.1 to DEBIAN May 24, 2018 09:32
@D-sha

D-sha commented May 27, 2018

Copy link
Copy Markdown
Author

Yep im looking into it but it may take some time - Im not a debian packaging expert.

Ill let you know when i have something,
Cheers,
Dean.

@D-sha

D-sha commented May 28, 2018

Copy link
Copy Markdown
Author

Sorry are you asking to add the patch to the rest of the patch series? Because i cant work out how to reference to the right location of the conf file.
If you are just talking about physically moving to the patches folder, I can do that.
Cheers,
Dean

@raoulbhatia

Copy link
Copy Markdown
Owner

Besides moving and testing it might be required to update the patches.

Details can be found at https://www.debian.org/doc/manuals/maint-guide/dother.en.html#patches and perhaps http://packaging.ubuntu.com/html/patches-to-packages.html#adding-a-new-patch

I hope this will help.
Raoul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants