Add RankSEG post-transform tests Ver.2#2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test strategy
tests/transforms/test_as_discrete.pyandtests/transforms/test_as_discreted.pyare part of MONAI's minimum test suite, butranksegis an optional dependency installed in the full/development environment. The tests therefore separate minimum-safe API coverage from the real optional dependency path.Minimum dependency tests still cover:
AsDiscrete/AsDiscretedbehavior;rankseg=Falsewithargmax=True;rankseg=Trueplusargmax=Trueincompatibility;OptionalImportError.Full/development tests additionally run a real RankSEG value/shape case. The chosen input is a two-class probability map.
For this input,
argmax=Trueproduces[[[1.0, 0.0]]], while the default RankSEG decoder produces[[1.0, 1.0]].AsDiscretedfull/development tests also cover dictionary forwarding, including the per-keyrankseg=[True, False]case.The real RankSEG cases are only added when the optional package is available, so minimum tests do not report dependency-related skips and continue to exercise the rest of the file.
Validation
Targeted tests passed locally:
Results:
pytest: 53 passedunittest: 53 passed