v2.12.4 — fix: updater used the wrong compose project name - #55
Merged
Conversation
The updater mounts the project at /project, and Compose derives the project name
from the directory name, so it inferred "project" while the real stack was
"waxflow". A mismatched project name makes Compose try to CREATE rather than
RECREATE, and every apply died immediately with:
Conflict. The container name "/waxflow-api" is already in use
Auto-update would have failed on every single run — the feature would have looked
installed and done nothing, which is the same failure mode this whole line of work
set out to eliminate.
Found by forcing an apply of the CURRENT version instead of waiting for a real
release to expose it. Worth noting the failure was safe: the stack stayed up and
healthy, and .update-result recorded "failed", so the fail-safe path is confirmed
working on a real failure rather than only a synthetic one.
Now detected from the running container's own com.docker.compose.project label,
so it is correct wherever the project lives on disk, with WAXFLOW_PROJECT_NAME as
an override.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HmUiLHPmKoz215WAWV5eHe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
The updater mounts the project at
/project, and Compose derives the project name from the directory name — so it inferredprojectwhile the running stack waswaxflow.A mismatched project name makes Compose try to create rather than recreate, so every apply died instantly:
Auto-update would have failed on every single run. The feature would have looked installed and done nothing — the same failure mode this whole line of work set out to eliminate.
How it was found
By forcing an apply of the current version (
POST /admin/update?force=true) rather than waiting for a real release to expose it.Worth noting the failure was safe, which is itself a useful result: the stack stayed up and healthy on 2.12.3, and
.update-resultrecordedfailed. The rollback/fail-safe path is now confirmed against a genuine failure rather than only a synthetic one.The fix
Project name is detected from the running container's own
com.docker.compose.projectlabel, so it's correct wherever the project lives on disk.WAXFLOW_PROJECT_NAMEoverrides it.🤖 Generated with Claude Code
https://claude.ai/code/session_01HmUiLHPmKoz215WAWV5eHe