Skip to content

chore: add php 8.5 to tests#313

Merged
rancoud merged 4 commits into
masterfrom
chore/add-php85
May 31, 2026
Merged

chore: add php 8.5 to tests#313
rancoud merged 4 commits into
masterfrom
chore/add-php85

Conversation

@rancoud

@rancoud rancoud commented May 30, 2026

Copy link
Copy Markdown
Owner

Description

  • add php 8.5 to test workflow
  • avoid double run on github action
  • add --display-all-issues on phpunit command
  • remove lint action on php 8.5
  • remove PHP_CS_FIXER_IGNORE_ENV=True for lint
  • replace in test \chr(99999999) with "\xFF"

Replace in escAttr

$ord = \ord($chr);

with

if (\strlen($chr) === 1) {
    $ord = \ord($chr);
} else {
    $ord = \mb_ord($chr, 'UTF-8');
}

@codecov

codecov Bot commented May 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (85be6a3) to head (a72f360).

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #313   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity        31        32    +1     
===========================================
  Files              1         1           
  Lines            105       107    +2     
===========================================
+ Hits             105       107    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rancoud rancoud merged commit 4fbc1ee into master May 31, 2026
4 checks passed
@rancoud rancoud deleted the chore/add-php85 branch May 31, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant