[main] Add admission validation for WebhookDeploymentCustomization#1465
Merged
Conversation
crobby
force-pushed
the
webhook-deployment-validation
branch
2 times, most recently
from
764e852 to
ff06e2a
Compare
This was referenced May 26, 2026
Draft
crobby
changed the title
crobby
force-pushed
the
webhook-deployment-validation
branch
from
ff06e2a to
018aebb
Compare
crobby
force-pushed
the
webhook-deployment-validation
branch
3 times, most recently
from
ebc4e54 to
0d410d1
Compare
Validate WebhookDeploymentCustomization fields on both provisioning.cattle.io/v1 and management.cattle.io/v3 Cluster resources: - replicaCount must be >= 1 - appendTolerations keys validated against k8s label name rules - overrideAffinity label selectors validated - PDB minAvailable/maxUnavailable: non-negative int or 0-100% string, cannot both be non-zero simultaneously Shared validation logic lives in pkg/resources/common/deployment_customization.go to avoid duplication across API groups.
crobby
force-pushed
the
webhook-deployment-validation
branch
from
0d410d1 to
1090534
Compare
rohitsakala
reviewed
Jun 8, 2026
rohitsakala
reviewed
Jun 8, 2026
crobby
force-pushed
the
webhook-deployment-validation
branch
from
614826a to
fed25b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: rancher/rancher#54090
Problem
Invalid
WebhookDeploymentCustomizationvalues (zero replicas, malformed toleration keys, conflicting PDB fields) pass through the API and only fail at Helm install time on the downstream cluster, making errors difficult to diagnose.Solution
Add admission validators for
WebhookDeploymentCustomizationreplicaCountmust be >= 1minAvailableandmaxUnavailablecannot both be non-zero