add extension that showcases setup for unit tests - #113
Merged
Conversation
…owcases unit tests + fix small bug with extensions-api-demo
torchiaf
approved these changes
Jul 22, 2026
torchiaf
left a comment
torchiaf
left a comment
Member
There was a problem hiding this comment.
LGTM - see the previous comment even if it's optional.
For the future, we could create a CLI command, similar to npx rancher-cypress init for creating the unit tests directories scaffold
|
|
||
| import { useCounter } from '../composables/useCounter'; | ||
|
|
||
| export default defineComponent({ |
Member
There was a problem hiding this comment.
Nit - we moved from old Vue syntax + Options API to the new one along with Composition API. I think we should the same for this example, which is oriented to new adoptors. wdyt ?
torchiaf
self-requested a review
July 22, 2026 15:02
torchiaf
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rancher/dashboard#18312
Based on the work done in rancher/dashboard#18304