test(e2e): match home-page counts/namespaces waits with or without pagesize - #18658
Open
marcelofukumoto wants to merge 1 commit into
Open
test(e2e): match home-page counts/namespaces waits with or without pagesize#18658marcelofukumoto wants to merge 1 commit into
marcelofukumoto wants to merge 1 commit into
Conversation
Contributor
|
🔄 Auto-Retry Failed Run The Tests workflow failed for the commits below and has been automatically retried.
|
marcelofukumoto
force-pushed
the
fix-regex-regression-e2e-test
branch
from
August 5, 2026 12:47
0da50e5 to
207b2dd
Compare
richard-cox
requested changes
Aug 6, 2026
richard-cox
left a comment
Member
There was a problem hiding this comment.
master now tracks 2.16 and in this release pagination will always been enabled. this one would need to go into previous branches only. however those branches are fine and pass gates. i think we can leave this one
Member
Author
|
This was to fix the usage on the local environment usage of the Cypress. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Cypress home-page readiness helper (
HomePagePo.goToAndWaitForGet) intercepts andwaits for the
v1/countsandv1/namespacesrequests with a hardcodedpagesize=<defaultPageSize>query param:That param is only sent when the dashboard uses server-side (sql-cache) pagination — i.e.
it depends on the dashboard build and the backend advertising pagination support. Against a
backend/UI that does not paginate those calls, the request is
v1/counts?exclude=…(no
pagesize), so the intercept never matches andcy.wait('@getUrl0')times out after10s. The result is a flaky/failing readiness wait when the specs run against a backend whose
UI doesn't send
pagesize(e.g. an older release line), even though login and the page loadfine.
Occurred changes and/or fixed issues
HomePagePo.goToAndWaitForGetnow matches these calls with a regex that fires the waitwhether or not
pagesizeis present (and regardless of its value):PagePo.goToAndWaitForGetsignature widened fromstring[]to(string | RegExp)[]soregex matchers are accepted (backwards compatible — existing string callers are unaffected).
PAGINATION_UTILSimport fromhome.po.ts.Technical notes summary
counts/namespacesresponse before proceeding; it just no longer pins the exact URL shape.
PAGINATION_UTILS.defaultPageSizevalue, so a futurechange to the default page size won't silently break the wait.
Areas or cases that should be tested
HomePagePo.goToAndWaitForGet(a large portion ofthe suite) — confirm the page-ready wait still passes on CI (paginated backend).
pagesize(older release line).Areas which could experience regressions
counts/namespacescollection calls (anchored on
?…exclude=metadata.managedFields), so it won't matchunrelated requests.
Screenshot/Video
N/A — test-infrastructure change, no UI impact.
Checklist
Admin,Standard UserandUser Base