Skip to content

Create nightly tests for extension workflows in branch 'master' - #12595

Merged
aalves08 merged 4 commits into
rancher:masterfrom
aalves08:12032-reusable-wf-tests-3
Nov 25, 2024
Merged

Create nightly tests for extension workflows in branch 'master'#12595
aalves08 merged 4 commits into
rancher:masterfrom
aalves08:12032-reusable-wf-tests-3

Conversation

@aalves08

@aalves08 aalves08 commented Nov 13, 2024

Copy link
Copy Markdown
Member

Summary

Fixes #12159
Fixes #12032

Based on the work done in aalves08#4

Occurred changes and/or fixed issues

Note: Necessary github secret has already been added to the repo

Technical notes summary

Example of a workflow run with a failure in a job: https://github.com/aalves08/dashboard/actions/runs/11817619114 + https://github.com/aalves08/dashboard/actions/runs/11817619114/job/32923438990
Example of a workflow run with all jobs succeeded: https://github.com/aalves08/dashboard/actions/runs/11817653117 + slack message: https://github.com/aalves08/dashboard/actions/runs/11817653117/job/32923642602

Key takeaways

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@aalves08 aalves08 added this to the v2.10.1 milestone Nov 13, 2024
@aalves08
aalves08 requested review from jordojordo and nwmac November 13, 2024 14:56
@aalves08 aalves08 self-assigned this Nov 13, 2024
@aalves08
aalves08 force-pushed the 12032-reusable-wf-tests-3 branch from f5564e1 to 32aad70 Compare November 14, 2024 16:09
… be populated as that job doesnt run in these workflow tests

@jordojordo jordojordo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - nice work!

@aalves08
aalves08 merged commit c0e4d97 into rancher:master Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create test for creators lib Create automated test to check reusable workflow for publishing extensions

2 participants