start mcp client #3
Open
MarquiseRosier wants to merge 7 commits into
Open
Conversation
MarquiseRosier
marked this pull request as ready for review
June 4, 2025 09:08
ramboz
reviewed
Jun 4, 2025
added 2 commits
June 4, 2025 12:13
ramboz
approved these changes
Jun 4, 2025
| let encoder; | ||
|
|
||
| export async function loadBundles(url, date, domainkey, ckpt) { | ||
| const endpoint = `https://bundles.aem.page/bundles/${url}/${date}?domainkey=${domainkey}`; |
There was a problem hiding this comment.
Suggested change
| const endpoint = `https://bundles.aem.page/bundles/${url}/${date}?domainkey=${domainkey}`; | |
| const endpoint = `${process.env.RUM_ENDPOINT}/${encodeURIComponent(url)}/${date}?domainkey=${domainkey}`; |
| const OUTPUT_DIR = './.cache'; | ||
| let encoder; | ||
|
|
||
| export async function loadBundles(url, date, domainkey, ckpt) { |
There was a problem hiding this comment.
Suggested change
| export async function loadBundles(url, date, domainkey, ckpt) { | |
| export async function loadBundles(url, date, domainkey) { |
nitpick, ckpt isn't used
| "license": "ISC", | ||
| "description": "", | ||
| "dependencies": { | ||
| "@adobe/rum-distiller": "github:adobe/rum-distiller", |
There was a problem hiding this comment.
Why install from GitHub and not from npm? https://www.npmjs.com/package/@adobe/rum-distiller
@adobe/rum-distiller
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting to build out MCP Client using Spacecat