fix: keep global delete action related wording intact - #13
Open
artemv wants to merge 2 commits into
Open
Conversation
also, * show Restore button at Show page only if it's archived * show Delete button at Show page only if it's archived * removed unneeded to_s...constantize sequences Notice that if you have custom archive action related translations you'll need to rename and move them similar to how this commit does in en.yml. fixes raihan2006i#10
… activeadmin model registration fixes raihan2006i#10
Owner
|
@artemv Thanks for the pull request, apologies for replying after long time. I will test and merge this during 🎄 holidays |
Collaborator
|
@artemv This looks excellent, thanks! I am pulling your change into my fork. I still use ActiveAdmin and paranoia, so this gem is really helpful! It still works great even though it hasn't been updated for a while. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also,
Notice that if you have custom archive action related translations
you'll need to rename and move them similar to how this commit does in
en.yml.
fixes #10