[Specs][OpenAPI] Stabilize builder title specs across checkout names#346
Open
RedZapdos123 wants to merge 2 commits into
Open
[Specs][OpenAPI] Stabilize builder title specs across checkout names#346RedZapdos123 wants to merge 2 commits into
RedZapdos123 wants to merge 2 commits into
Conversation
Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Issue #345 reported that the mocked OpenAPI builder specs hardcode
"title" => "Rage"while the current default title is derived fromRage.root.basename.This PR keeps the current runtime behavior unchanged and stabilizes the mocked OpenAPI builder specs by stubbing
Rage.rootto a fixedragepath in the sharedmocked_rage_routestest context.That keeps the builder specs independent of the local checkout directory basename without changing
Rage::OpenAPI::Converter.It also adds the matching changelog entry required by the repository workflow.
Closes #345.
Before fix:
After fix:
Checklist:
CHANGELOG.md.ragecheckout usingbundle exec ruby /mnt/c/Users/Xeron/Desktop/FOSS/FOSSContributons20/.tmp/openapi-title-drift-evidence/title_repro.rb.bundle exec rspec spec/openapi/builder/base_spec.rb:16 --format documentation.bundle exec rspec spec/openapi.