CompatHelper: bump compat for AlgebraOfGraphics in [extras] to 0.13, (keep existing compat)#1203
Open
github-actions[bot] wants to merge 1 commit into
Conversation
…(keep existing compat)
rafaqz
force-pushed
the
compathelper/new_version/2026-06-26-02-00-14-291-01315775500
branch
from
June 26, 2026 02:00
206eb6c to
0f27ad5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #1203 +/- ##
==========================================
- Coverage 86.99% 80.14% -6.85%
==========================================
Files 61 61
Lines 5850 5843 -7
==========================================
- Hits 5089 4683 -406
- Misses 761 1160 +399 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
Should have been fairly harmless https://github.com/MakieOrg/AlgebraOfGraphics.jl/blob/master/CHANGELOG.md |
asinghvi17
added a commit
to asinghvi17/DimensionalData.jl
that referenced
this pull request
Jun 28, 2026
Under Makie 0.24 / CairoMakie 0.15, 3D plots (`volume`, `volumeslices`, `plot` of a 3D `DimArray`) now build a 2D `Makie.Axis` instead of an `LScene`, and `surface` accepts a previously-invalid `xlabel` axis attribute without throwing `InvalidAttributeError`. These are upstream behaviour changes (tracked in rafaqz#1199) that break the existing assertions in test/makie.jl, turning CI red on every PR (e.g. rafaqz#1203). Mark the three affected assertions as `broken = true` (matching the existing convention at test/makie.jl:427-430) so the suite passes while clearly flagging the regression. When the Makie extension is reworked to restore 3D axes, these will report as unexpected passes and can be flipped back to plain `@test`. This is a test-only stopgap; the underlying LScene -> Axis regression in DimensionalDataMakieExt (rafaqz#1199) still needs a real fix. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
AlgebraOfGraphicspackage from0.8, 0.9, 0.10, 0.11, 0.12to0.8, 0.9, 0.10, 0.11, 0.12, 0.13.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.