fix(uppy): JSON-encode Array/Hash direct-upload values for Stimulus - #121
Open
thedumbtechguy wants to merge 1 commit into
Open
fix(uppy): JSON-encode Array/Hash direct-upload values for Stimulus#121thedumbtechguy wants to merge 1 commit into
thedumbtechguy wants to merge 1 commit into
Conversation
The attachment-input controller declares allowedFileTypes (and requiredMetaFields) as Stimulus Array value types, which are read with JSON.parse. Phlex renders an array attribute value space-joined (its class-list behaviour), so `allowed_file_types: [".csv", "text/csv"]` reached the controller as ".csv text/csv" — JSON.parse threw on connect, after the native file input had already been hidden, leaving the user with no usable file picker. Emit structured values as JSON, matching the existing intl_tel_input options pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The attachment-input controller declares allowedFileTypes (and requiredMetaFields) as Stimulus Array value types, which are read with JSON.parse. Phlex renders an array attribute value space-joined (its class-list behaviour), so
allowed_file_types: [".csv", "text/csv"]reached the controller as ".csv text/csv" — JSON.parse threw on connect, after the native file input had already been hidden, leaving the user with no usable file picker. Emit structured values as JSON, matching the existing intl_tel_input options pattern.