Skip to content

fix #7802 explicity redirect to jupyterhublogin on missing cookies #7958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
moellep merged 1 commit into from
Jul 9, 2026
Merged

fix #7802 explicity redirect to jupyterhublogin on missing cookies #7958

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions sirepo/jupyterhub.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,19 +64,14 @@ def _request(cookies):
_cookies(r)
return r

c = {k: handler.get_cookie(k) for k in handler.cookies.keys()}
r = _request(c)
r = _request({k: handler.get_cookie(k) for k in handler.cookies.keys()})
u = _redirect_uri(r)
if u and _MISSING_COOKIES_URI_PART in u and r.cookies:
# First contact with Sirepo; retry once with the cookie
# sentinel it just set, rather than assume cookies are
# unsupported.
c.update(r.cookies.get_dict())
r = _request(c)
u = _redirect_uri(r)
if r.status_code == requests.codes.forbidden:
return PKDict()
r.raise_for_status()
if u and _MISSING_COOKIES_URI_PART in u:
# redirect to /jupyterhublogin which handles missing cookies correctly
u = f"/{SIM_TYPE}"
if u:
_handle_unauthenticated(u)
res = PKDict(r.json())
Expand Down