fix #7802 retry with current cookies if first request is cookie redirect - #7956
Merged
Conversation
robnagler
approved these changes
Jul 9, 2026
robnagler
left a comment
robnagler
left a comment
Member
There was a problem hiding this comment.
Went through the logic and seems ok.
Member
Author
|
It may fail oddly if a client has cookies disabled, but this is hard to test on dev. I'll try this on alpha. It is more important that the first visit works for uncookied users than the case where all cookies are disabled. |
Member
|
The only thing to worry about is a loop. I don't think that would happen, but good to test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.