Skip to content
This repository was archived by the owner on Feb 7, 2019. It is now read-only.

Fix imports to remove warning per Flask recommendation.#20

Open
galund wants to merge 2 commits into
rachelsanders:masterfrom
Crown-Commercial-Service:fix_imports
Open

Fix imports to remove warning per Flask recommendation.#20
galund wants to merge 2 commits into
rachelsanders:masterfrom
Crown-Commercial-Service:fix_imports

Conversation

@galund

@galund galund commented Dec 20, 2017

Copy link
Copy Markdown

Flask no longer recommend using the "flask.ext." import style; this change eliminates the warning currently generated by flask when using this extension.

http://flask.pocoo.org/docs/0.12/extensiondev/#extension-import-transition

(The 0.12 docs are somewhat contradictory on this, but the confusing text seems to have been removed in the latest dev docs.)

@coveralls

coveralls commented Dec 20, 2017

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 95.489% when pulling b8e8711 on alphagov:fix_imports into bf32d07 on trustrachel:master.

@pcraig3 pcraig3 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this looks totally good to me.

 - this tiny library is stable. Round numbers are nice.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants