refactor(install): one home for the prior-install ownership invariant - #36
Merged
Merged
Conversation
The foreign-target refusal + --force warning block existed verbatim in both installClaude and installCodex; assertOwnInstallTarget now owns it. isSafeToOverwrite also probes all three harness manifests through one loop instead of two copied blocks, covering .opencode-plugin payloads that previously fell through to the empty-dir heuristic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Architecture-review follow-up (ai-catapult front, bounded slice).
Reading
install.jshonestly revised the original review: the three harness installers are already clean section seams, so extracting them to files would relocate complexity rather than concentrate it. The real duplication was smaller and is now fixed:assertOwnInstallTarget()owns the foreign-target refusal +--forcewarning that existed verbatim in bothinstallClaudeandinstallCodexisSafeToOverwrite()probes all three harness manifests via one loop (previously.opencode-pluginpayloads fell through to the empty-dir heuristic)Gates:
npm test188 passed / 0 failed. The larger host-installer seam stays staged for a planned run rather than forced here.