Add -mbig-obj flag for windows debug builds - #223
Open
andrjohns wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A long-standing gripe for windows devs of stan-based R packages is the
too many sectionserror when usingdevtools::load_all(), caused by compiling packages with debug symbols and no optimisation.Traditionally, we've just advised users to add the
-Wa,-mbig-objflag to their Makevars when developing, but the queries are still raised and there can be confusion about when to remove the flag.Adding the flag in
pkgbuilddirectly would be a big help (both for user experience and reducing queries!)Thanks!