Skip to content

Callback registries should be cleared when process is forked #142

Description

@wch

This is a follow-up to #141.

When the R process is forked with future, the child process gets a copy of the event loop, but it should be cleared out in the child process.

Example:

library(later)
library(future)

# Enable forked process
options(future.fork.enable = TRUE)
plan(multicore, workers = 2)

ff <- function(){
  message( Sys.getpid())
  later::later(ff, 2)
}
ff()

fs <- replicate(2, {
  future({
    for (i in 1:1000) {
      later::run_now(timeout = 1)
    }
  })
})

This will output:

18235
18241
18242
18235
18241
18242
...

The callback registries should be cleared out when the process is forked. However, we have to be careful about how we do this. What happens if the fork happens in the middle of executing a callback? Is it safe to clear out the C++ data structures at any time that a fork could happen? (Normally the callbacks are removed after being executed.)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions