Show results in leaderboard#12
Open
verutrix wants to merge 2 commits into
Open
Conversation
…t it displays leader-board instead before closing the quiz.
verutrix
requested review from
JanaDrazkova,
ZelenyMartin,
dslavicek,
ninabel and
papricie
as code owners
ZelenyMartin
previously approved these changes
Jun 7, 2026
ZelenyMartin
reviewed
Jun 7, 2026
ZelenyMartin
left a comment
ZelenyMartin
left a comment
Contributor
There was a problem hiding this comment.
I think the logic of processing game log data should be done on a quiz-admin side. Unlike quiz-client, I hope we can consider the quiz-admin as a more or less "safe" environment for data handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change checks if we are showing results or more questions. When it's time to show the results it displays leader-board first before closing the quiz.