refactor: extract sessions state - #88
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what changed
SessionsStateowner with exactly 23 browser, discovery, viewport, identity/mode, new-session, activity, and remembered remote-location fieldsAppfields with onepub(crate) sessions: SessionsState, reducing directAppfields from 89 to 67launch_cwdanddelegate_popup_visible_rowsflat; preserve the focusedreset_active_session_viewlifecycle boundaryscope and metrics
3a7a599ff0fb04def35f2ba1591d3623dc5e9ba0dcc88cbc2be93550c394f8e8bd6dab2ec910c2besrc/session_state.rs,src/lib.rs,src/app.rs,src/session.rs,src/acp_state.rs,src/handlers.rs,src/mesh.rs,src/runtime/mod.rs,src/runtime/event_loop.rs,src/ui/start.rs,src/ui/popups.rs,src/ui/chat.rs,src/ui/mod.rsAppfields, fiveAppimpl files, 23SessionsStatefields, 848 test declarationsvalidation
cargo fmt --all -- --checkcargo check --all-targets --all-featurescargo clippy --all-targets --all-features -- -D warningscargo build --all-targets --all-featurescargo test --all-targets --all-features(848 passed, 0 failed/ignored)git diff --checkboundary proof
mod session_state;, oneApp::sessions, and 23 owner fieldscrate::app::{StartPageItem, PopupItem, PathCompletionState}pathsFileIndexEntryLitedependencylaunch_cwdanddelegate_popup_visible_rowsare each declared once onAppand absent from the ownerphase 11 compatibility forwardtags remainresiduals