refactor: remove legacy protocol scaffolding - #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes
ClientMsg/SessionScopeoutbound types, protocolPromptBlock, associated helpers, and serializer testsAgentEvent/mesh-invite-list and other orphan protocol DTOsEventKindpayloads, mesh/remote, and auth/oauth DTOs with their active tests{ "timestamp": 123, "kind": { "type": "...", "data": { ... } } }, usingkind: EventKindandtimestamp: Option<i64>#![allow(dead_code)]; no localdead_code/cfg_attrallowances are introduced by this PRvalidation
cargo fmt --checkcargo check --all-targets --all-featurescargo clippy --all-targets --all-features -- -D warningscargo build --all-targets --all-featurescargo test --all-features(734 passed)src/lib.rsmatches the base, and the final base diff touches onlysrc/app.rsandsrc/protocol.rsdeferred
Crate-wide dead-code cleanup and the broader event/UI/session migration are intentionally deferred, including protocol splitting and
EventKindredesign.