Extract Mutation Strategy from RankInvariantChecker and Update Tests - #51
Open
BashithaShamila wants to merge 1 commit into
Open
Extract Mutation Strategy from RankInvariantChecker and Update Tests#51BashithaShamila wants to merge 1 commit into
BashithaShamila wants to merge 1 commit into
Conversation
Collaborator
I imagine something like: def my_mutation(**kwargs): # we must decide with "kwargs" are necesary
....
rrt1 = RankInvariantChecker(mutation_strategy=my_mutation)My suggestions are to reduce the number of new modules, reduce the number of new documentation and obviously reduce the number of testing. Making this code more maintainable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this pull request, I have refactored the RankInvariantChecker class by extracting the mutation strategy into a separate MutationStrategy interface. This enhancement promotes greater modularity and flexibility, allowing developers to easily implement and integrate custom mutation strategies without modifying the core RankInvariantChecker logic. Additionally, I introduced a default mutation strategy implementation and updated the relevant tests to ensure seamless functionality with the new structure. These changes improve the maintainability and extensibility of the codebase, facilitating future enhancements and adaptations.