Move away from deprecated darken, lighten, and import constructs in css - #2984
Open
holly-cummins wants to merge 1 commit into
Open
Move away from deprecated darken, lighten, and import constructs in css#2984holly-cummins wants to merge 1 commit into
holly-cummins wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
holly-cummins
force-pushed
the
fix-css-deprecation-warnings
branch
from
September 4, 2026 11:41
e7e1ad2 to
677f8da
Compare
Status for workflow
|
|
🎊 PR Preview c1e90b2 has been successfully built and deployed to https://quarkus-website-pr-2984-preview.surge.sh
|
Member
|
I will let @insectengine review this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sass processor used by Roq is a bit grumpier about deprecation than the one used by Jekyll, so we're getting deprecation warnings about
@importin the logs. I've used Bob to fix things up, but it's an invasive change. All looks well to me running locally but I don't have a deep knowledge of sass to be able to judge if Bob made good design choices. I passed Bob's work through Claude, which made a few further revisions.