Skip to content

Fix upload_pypi: artifact download mismatch and missing release permission#45

Closed
RobinDavid with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-upload-pypi-job-again
Closed

Fix upload_pypi: artifact download mismatch and missing release permission#45
RobinDavid with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-upload-pypi-job-again

Conversation

Copilot AI commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

The upload_pypi job was failing because a workflow update introduced pattern: artifact_* for artifact download, which doesn't match the artifact uploaded as name: artifact — resulting in an empty dist/ and a PyPI publish failure.

Changes

  • Artifact download (actions/download-artifact@v8): Restored name: artifact instead of pattern: artifact_*, which matched zero artifacts and caused the empty dist/ directory error.
  • Job permissions: Added contents: write alongside id-token: write so softprops/action-gh-release can upload assets to the GitHub release. Specifying any permissions block drops all defaults, so without this the release asset upload would silently fail once PyPI publish succeeds.
# Before
pattern: artifact_*   # never matched "artifact"
merge-multiple: true
permissions:
  id-token: write     # contents: write dropped, breaking release upload

# After
name: artifact
permissions:
  id-token: write
  contents: write

Copilot AI changed the title [WIP] Fix failing GitHub Actions job upload_pypi Fix upload_pypi: artifact download mismatch and missing release permission Jun 28, 2026
Copilot AI requested a review from RobinDavid June 28, 2026 14:14
@RobinDavid RobinDavid closed this Jun 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants