Repository navigation
Move Fermi-Hubbard publication data fetching - #488
Open
Mounika-2604 wants to merge 1 commit into
Open
Mounika-2604 wants to merge 1 commit into
Mounika-2604 wants to merge 1 commit into
Conversation
Author
|
Hi @mhucka, the changes for this issue are ready. Could you please review the PR when you have a chance? Thank you! |
mhucka
requested changes
Oct 6, 2026
mhucka
left a comment
Collaborator
There was a problem hiding this comment.
The PR description is longer than the changes in the PR itself. It was obviously written by an AI agent. Don't just copy-paste the output from an agent. Summarize what is being done in your own words. Please respect the time of your human reviewers.
Author
|
I apologize for that, @mhucka. You're completely right — the previous description was unnecessarily verbose for such a small change. I have updated the PR description with a concise summary of what was actually changed. Thank you for pointing that out and for taking the time to review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #125.
Summary
Following the decision in #125 to keep publication data fetching in the experiment modules:
get_publication_dataas an alias forfetch_publication_datainrecirq/fermi_hubbard/publication.py.recirq/fermi_hubbard/__init__.py.publication_test.pyto verify the alias and export.Testing
pytestlocally onrecirq/fermi_hubbard/(all tests passed).