Refactor Router and ModuleLoader: Decouple module loading from route building - #409
Merged
Conversation
armanist
requested review from
Arno2005,
Wiltzsu,
charoyan88,
grigoryanmartin20,
hatik92 and
live-soft
January 18, 2026 12:27
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #409 +/- ##
============================================
- Coverage 79.90% 79.88% -0.02%
- Complexity 2492 2495 +3
============================================
Files 229 230 +1
Lines 6609 6623 +14
============================================
+ Hits 5281 5291 +10
- Misses 1328 1332 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrey-smaelov
approved these changes
Jan 18, 2026
live-soft
approved these changes
Jan 19, 2026
armanist
deleted the
383-Refactor-Router-&-ModuleLoader-Introduce-Route-as-Single-Route-Entity-and-Decouple-Module-Loading
branch
January 19, 2026 12:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ModuleLoaderno longer executes module route closures or builds runtime routes.It only loads module
configs/dependenciesand returns module route definition closures.RouteBuilderis responsible for executing those closures using the existing Route DSL collectorand producing the final runtime routes array that
Routerexpects today.IMPORTANT:
RouteController/Routerstill operate on route arrays at this stage.Routeobject-centric internal representation will be done in a follow-up,because it requires coordinated changes across
Routermatching,RouteControllerstate and helpers.