Skip to content

Commit 0da6883

Browse files
committed
[#518] Fix middleware template signature mismatches
1 parent c236264 commit 0da6883

4 files changed

Lines changed: 5 additions & 4 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@
8181
- Fixed cURL error message assertions for cross-version compatibility
8282
- Fixed SleekDB paginator query-state regression where `count()` could clear criteria before paginated data fetch on the same model instance (#514)
8383
- Standardized `defineValidationRules(Request $request): void` across DemoWeb and DemoApi middleware templates
84+
- Standardized `defineValidationRules(Request $request): void` in Toolkit middleware templates
8485

8586
### Added
8687
- `AppContext` class representing the runtime identity of a single application execution

src/Module/Templates/DemoWeb/src/Middlewares/Password.php.tpl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,10 @@ class Password extends BaseMiddleware
6464
/**
6565
* @inheritDoc
6666
*/
67-
protected function respondWithError(Request $request, $message)
67+
protected function respondWithError(Request $request, $message): Response
6868
{
6969
session()->setFlash('error', $message);
70-
redirectWith(base_url(true) . '/' . current_lang() . '/account-settings#account_password', $request->all());
70+
return redirectWith(base_url(true) . '/' . current_lang() . '/account-settings#account_password', $request->all());
7171
}
7272

7373
/**

src/Module/Templates/Toolkit/src/Middlewares/BaseMiddleware.php.tpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ abstract class BaseMiddleware extends Middleware
4949
/**
5050
* Define validation rules specific to middleware.
5151
*/
52-
protected function defineValidationRules(Request $request)
52+
protected function defineValidationRules(Request $request): void
5353
{
5454
// default no-op: subclasses override if needed
5555
}

src/Module/Templates/Toolkit/src/Middlewares/CreateTable.php.tpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ class CreateTable extends BaseMiddleware
3939
/**
4040
* @inheritDoc
4141
*/
42-
protected function defineValidationRules(Request $request)
42+
protected function defineValidationRules(Request $request): void
4343
{
4444
$this->registerCustomRules();
4545

0 commit comments

Comments
 (0)