Merge pull request #517 from armanist/issue/516-middleware-void-signatures

[#516] Standardize middleware validation rule signatures

Author: armanist

CHANGELOG.md

@@ -80,6 +80,7 @@
 - Fixed deprecated `E_STRICT` constant usage in test bootstrap
 - Fixed cURL error message assertions for cross-version compatibility
 - Fixed SleekDB paginator query-state regression where `count()` could clear criteria before paginated data fetch on the same model instance (#514)
+- Standardized `defineValidationRules(Request $request): void` across DemoWeb and DemoApi middleware templates
 
 ### Added
 - `AppContext` class representing the runtime identity of a single application execution

src/Module/Templates/DemoApi/src/Middlewares/Activate.php.tpl

@@ -44,7 +44,7 @@ class Activate extends BaseMiddleware
     /**
      * @inheritDoc
      */
-    protected function defineValidationRules(Request $request)
+    protected function defineValidationRules(Request $request): void
     {
         $this->validator->setRules([
             'token' => [

src/Module/Templates/DemoApi/src/Middlewares/BaseMiddleware.php.tpl

@@ -14,9 +14,9 @@
 
 namespace {{MODULE_NAMESPACE}}\Middlewares;
 
-use Quantum\Validation\Validator;
 use Quantum\Http\Enums\StatusCode;
 use Quantum\Middleware\Middleware;
+use Quantum\Validation\Validator;
 use Quantum\Http\Response;
 use Quantum\Http\Request;
 use Closure;
@@ -42,7 +42,7 @@ abstract class BaseMiddleware extends Middleware
     /**
      * Define validation rules specific to middleware.
      */
-    protected function defineValidationRules(Request $request)
+    protected function defineValidationRules(Request $request): void
     {
         // default no-op: subclasses override if needed
     }
@@ -62,10 +62,7 @@ abstract class BaseMiddleware extends Middleware
     /**
      * Handles error response logic.
      */
-    protected function respondWithError(Request $request,
-        $message,
-        int $status = StatusCode::UNPROCESSABLE_ENTITY
-    ): Response
+    protected function respondWithError(Request $request, $message, int $status = StatusCode::UNPROCESSABLE_ENTITY): Response
     {
         return response()->json([
             'status' => 'error',

src/Module/Templates/DemoApi/src/Middlewares/Comment.php.tpl

@@ -37,7 +37,7 @@ class Comment extends BaseMiddleware
     /**
      * @inheritDoc
      */
-    protected function defineValidationRules(Request $request)
+    protected function defineValidationRules(Request $request): void
     {
         $this->validator->setRules([
             'content' => [

src/Module/Templates/DemoApi/src/Middlewares/Editor.php.tpl

@@ -63,7 +63,7 @@ class Editor extends BaseMiddleware
     /**
      * @inheritDoc
      */
-    protected function defineValidationRules(Request $request)
+    protected function defineValidationRules(Request $request): void
     {
         if ($request->hasFile('image')) {
             $this->validator->setRules([

src/Module/Templates/DemoApi/src/Middlewares/Password.php.tpl

@@ -41,7 +41,7 @@ class Password extends BaseMiddleware
     /**
      * @inheritDoc
      */
-    protected function defineValidationRules(Request $request)
+    protected function defineValidationRules(Request $request): void
     {
         $this->registerCustomRules($request);
 

src/Module/Templates/DemoApi/src/Middlewares/Signup.php.tpl

@@ -38,7 +38,7 @@ class Signup extends BaseMiddleware
     /**
      * @inheritDoc
      */
-    protected function defineValidationRules(Request $request)
+    protected function defineValidationRules(Request $request): void
     {
         $this->validator->setRules([
             'email' => [

src/Module/Templates/DemoApi/src/Middlewares/Update.php.tpl

@@ -39,7 +39,7 @@ class Update extends BaseMiddleware
     /**
      * @inheritDoc
      */
-    protected function defineValidationRules(Request $request)
+    protected function defineValidationRules(Request $request): void
     {
         $this->validator->setRules([
             'firstname' => [

src/Module/Templates/DemoApi/src/Middlewares/Verify.php.tpl

@@ -40,7 +40,7 @@ class Verify extends BaseMiddleware
     /**
      * @inheritDoc
      */
-    protected function defineValidationRules(Request $request)
+    protected function defineValidationRules(Request $request): void
     {
         $this->validator->setRules([
             'otp' => [

src/Module/Templates/DemoWeb/src/Middlewares/Activate.php.tpl

@@ -45,7 +45,7 @@ class Activate extends BaseMiddleware
     /**
      * @inheritDoc
      */
-    protected function defineValidationRules(Request $request)
+    protected function defineValidationRules(Request $request): void
     {
         $this->validator->setRules([
             'token' => [