Skip to content

Merge updates from fork#130

Open
shanshanxu33 wants to merge 37 commits into
quantling:masterfrom
shanshanxu33:master
Open

Merge updates from fork#130
shanshanxu33 wants to merge 37 commits into
quantling:masterfrom
shanshanxu33:master

Conversation

@shanshanxu33

Copy link
Copy Markdown

This pull request includes recent updates and fixes made in my fork of JudiLing.jl.
The fork has been synced with the latest version of the upstream repository.

@MariaHei

Copy link
Copy Markdown
Collaborator

Hi @shanshanxu33
Sorry I haven't reacted earlier, I missed this one.
Thank you very much for implementing these changes and contributing to JudiLing!

In order for me to be able to properly review this PR, please do the following:

  1. Write a description of the changes you have made.
  2. Run the existing tests as described here. Some of the tests currently fail when I run them on this version of the code.
  3. Write additional tests covering your new features, making sure it covers both expected scenarios as well as edge cases.

Looking forward to being able to include this work and improving JudiLing!

why this merge is necessary, # especially if it merges an updated
upstream into a topic branch.
Merge backup-master into master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants