notionConfig file and Concurrent Vault Uploads - #6
Open
zedeff19 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there! 👋
I’ve made a couple of improvements that I think will make the project easier to maintain and a bit faster to use:
Central Notion Config:
I added a notionConfig.ts file at the base of the project. This lets you set the Notion API version in one place and use it wherever you need it (right now, it’s used in notion.ts). This should make it easier to update the API version in the future without hunting through the code.
Faster Vault Uploads:
I updated the vault uploading process to use Promise.all() for concurrent uploads. This means the whole vault can be uploaded in parallel instead of one file at a time, which should make things noticeably quicker, especially for larger vaults.
Let me know if you have any questions or if there’s anything you’d like me to tweak!
Thanks for your work on this project—I’m excited to contribute.