Fix "I/O error: raw read" on Windows#71
Open
krison-qualcomm wants to merge 3 commits into
Open
Conversation
krison-qualcomm
force-pushed
the
krison/fix-raw-read-error-windows
branch
2 times, most recently
from
2258b60 to
0135118
Compare
Brian Cain (androm3da)
requested a review
from Jerome Haxhiaj (jeromehaxhiaj-qti)
- (systemc-components\common\include\loader.h): add O_BINARY flag for Windows to prevent binary file corruption -On Windows (MSYS2/MinGW), open() defaults to text mode which can corrupt binary files such as .so and .skel.so during ELF loading. Adding O_BINARY forces raw binary reads and resolves the raw read errors observed on Windows. - The flag is guarded with #ifdef _WIN32 as it is Windows-specific and not applicable on other platforms. Signed-off-by: Krishna Soni <krison@qti.qualcomm.com> Signed-off-by: krison-qualcomm <krison@qti.qualcomm.com>
Signed-off-by: krison-qualcomm <krison@qti.qualcomm.com>
krison-qualcomm
force-pushed
the
krison/fix-raw-read-error-windows
branch
2 times, most recently
from
e5942ff to
36b8ee2
Compare
Signed-off-by: Krishna Soni <krison@qti.qualcomm.com> Signed-off-by: krison-qualcomm <krison@qti.qualcomm.com>
krison-qualcomm
force-pushed
the
krison/fix-raw-read-error-windows
branch
from
36b8ee2 to
93f456d
Compare
Contributor
Member
yeah looks to me like that might be a bug in the script itself even? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-On Windows (MSYS2/MinGW), open() defaults to text mode which can corrupt binary files such as .so and .skel.so during ELF loading. Adding O_BINARY forces raw binary reads and resolves the raw read errors observed on Windows.
Signed-off-by: Krishna Soni krison@qti.qualcomm.com