ci: enable commit-msg qcom-preflight-check - #519
ci: enable commit-msg qcom-preflight-check#519Christopher Obbard (obbardc) wants to merge 3 commits into
Conversation
|
Seems to work fine for this PR. |
Christopher Obbard (obbardc)
changed the title
60c4d2e to
7fbe33b
Compare
|
It'd be interesting to see how compatible the outstanding PRs are with the commit check enabled... |
|
The commit message checker seems to hate the Assisted-by lines next to SoB :/ I guess we should send a patch for that there, but first chase some canonical reference for these somewhere |
thanks; that was the point of this PR; to see what may fail! :-). For me it seemed to hate any tag (e.g. not just Also, unrelated to this PR, I guess we need to document&lint the AI policy (e.g. |
Test jobs for commit 60c4d2e |
Test jobs for commit 7fbe33b |
Yup (Assisted-by is just one we use commonly)
There is an internal one for employees with some room for variations in our various OSS repositories. |
7fbe33b to
ab48eff
Compare
Test jobs for commit ab48eff |
I will report this to https://github.com/qualcomm/qcom-reusable-workflows |
armor-checkers verifies source-level (API) and binary-level (ABI) backwards compatibility of source code. This repository holds image recipes and scripts rather than a library exposing a stable API/ABI, so the check has nothing meaningful to compare and is not suitable to enable. Document why the check is disabled as a comment where it is disabled. Signed-off-by: Christopher Obbard <chris.obbard@oss.qualcomm.com>
Enable the previously disabled `commit-msg` check in the `qcom-preflight-checks` workflow. The check enforces that each commit in a pull request has both a subject and a body, that neither exceeds 72 characters per line and that blank lines separate the subject, body and the Signed-off-by trailer. This is the commit style CONTRIBUTING.md already asks contributors to follow so letting CI enforce it saves reviewers from repeating the same feedback by hand on every pull request. Signed-off-by: Christopher Obbard <chris.obbard@oss.qualcomm.com>
The `commit-msg` check enabled in the `qcom-preflight-checks` workflow already enforces that no line of a commit message should exceed 72 characters, so checking the same thing here only means a contributor gets told about the same problem twice. Drop the commit message length check from `lint-on-pr` workflow; including checking commit subjects. The length check is kept for the pull request title as that is not part of any commit message, thus not covered by the preflight check. The conventional commit form of the subject is still checked for both the title and the commits as the preflight check does not check that yet. Signed-off-by: Christopher Obbard <chris.obbard@oss.qualcomm.com>
ab48eff to
c1f78b2
Compare
Test jobs for commit c1f78b2 |
|
Christopher Obbard (@obbardc) let's perhaps move this to Draft until we can fix the original reusable workflow? |
2 participants
Turn on the previously disabled
commit-msgcheck in the Qualcomm preflight check workflow; as discussed in #436 (comment)